Skip to content

Bounty IPC Emotes fix#606

Merged
NotActuallyMarty merged 6 commits intoProjectOmu:masterfrom
CometVoid:fixIpcEmote
Mar 9, 2026
Merged

Bounty IPC Emotes fix#606
NotActuallyMarty merged 6 commits intoProjectOmu:masterfrom
CometVoid:fixIpcEmote

Conversation

@CometVoid
Copy link
Contributor

@CometVoid CometVoid commented Feb 24, 2026

About the PR

Lets IPCs Snap, Clap, Sigh, Whistle, and Cry again

Why / Balance

Bounty, plus they have these noises built in so this is a bugfix sort of?

Technical details

Edited some files that aren't omu unique, but it's mostly just commenting out blacklists

Media

https://cdn.discordapp.com/attachments/1474650769620733962/1475671144580251668/2026-02-23_17-25-52.mp4?ex=699e5559&is=699d03d9&hm=92be28fc6b33c714c22a3511ceee9aea7374ba50b251bd4865300d16798d13ec&
(link to message in bounty if discord embed fails) https://discord.com/channels/1406768242843979816/1474650769620733962/1475671147348492491

Requirements

Breaking changes

Changelog

🆑

  • fix: IPCs now make sound when they clap, snap, salute, sigh, whistle, and manually cough

@github-actions github-actions bot added S: Untriaged Has not been set a status; currently not labeled. Changes: No C# Purely YAML/non-C#. and removed S: Untriaged Has not been set a status; currently not labeled. labels Feb 24, 2026
Thesia000
Thesia000 previously approved these changes Feb 28, 2026
View reviewed changes
@Thesia000 Thesia000 dismissed their stale review February 28, 2026 16:34

missclick

NotActuallyMarty
NotActuallyMarty requested changes Feb 28, 2026
View reviewed changes
Copy link
Contributor

@NotActuallyMarty NotActuallyMarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't how you should be adding death sounds, as a damagetrigger will just make them activate upon reaching 100 damage of any kind, but mind you that you can accrue more than 100 damage on an IPC without dying due to vital damage changes.

@CometVoid
Copy link
Contributor Author

CometVoid commented Mar 4, 2026

ah yeah you're right, i'll fix that

@3PonPon3 3PonPon3 added Note: Bounty A pull-request made for a bounty or other offer. A: Character/Species Area: Player characters and species features and content. S: Needs Review Needs review by a maintainer. Type: Bugfix Fixes a known issue/bug. Type: Enhancement New feature or request, change to game. labels Mar 6, 2026
3PonPon3
3PonPon3 approved these changes Mar 6, 2026
View reviewed changes
Copy link
Contributor

@3PonPon3 3PonPon3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a triage maint so this doesn't count towards actually merging it but all looks good and lord this has been broken for so long, good to see a fix.

harryhulse12-alt
harryhulse12-alt approved these changes Mar 9, 2026
View reviewed changes
Copy link
Contributor

@harryhulse12-alt harryhulse12-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes tests

@github-actions github-actions bot added S: Approved This PR has been approved. and removed S: Needs Review Needs review by a maintainer. labels Mar 9, 2026
NotActuallyMarty
NotActuallyMarty approved these changes Mar 9, 2026
View reviewed changes
Copy link
Contributor

@NotActuallyMarty NotActuallyMarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might allow borgs to clap and stuff but i don't mind, fix / adjust later.

@Dishwasher0
Copy link
Contributor

Dishwasher0 commented Mar 9, 2026

This might allow borgs to clap and stuff but i don't mind, fix / adjust later.

Replace the clap whit the low bit rate one :godo:

@NotActuallyMarty NotActuallyMarty mentioned this pull request Mar 9, 2026
Open
@NotActuallyMarty NotActuallyMarty merged commit e9c42d8 into ProjectOmu:master Mar 9, 2026
14 checks passed
OmuStationBot added a commit that referenced this pull request Mar 9, 2026
@OmuStationBot
Automated Changelog Update (#606)
508e322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NotActuallyMarty NotActuallyMarty NotActuallyMarty approved these changes

@harryhulse12-alt harryhulse12-alt harryhulse12-alt approved these changes

@Thesia000 Thesia000 Thesia000 left review comments

+1 more reviewer

@3PonPon3 3PonPon3 3PonPon3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A: Character/Species Area: Player characters and species features and content. Changes: No C# Purely YAML/non-C#. Note: Bounty A pull-request made for a bounty or other offer. S: Approved This PR has been approved. size/S Type: Bugfix Fixes a known issue/bug. Type: Enhancement New feature or request, change to game.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@CometVoid @Dishwasher0 @NotActuallyMarty @Thesia000 @3PonPon3 @harryhulse12-alt @OmuStationBot